Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we split url and domain so that the url matches what the static cache expects #19

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

ryanmitchell
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Aug 28, 2024

PR Summary

  • New Properties in 'Invalidate' and 'InvalidateModel' Classes
    In the change request, new elements named 'tags' and 'model' have been added to the classes Invalidate and InvalidateModel respectively. These are needed to further enhance the functionality of these classes.

  • New Method in 'ServiceProvider' and 'Manager' Classes
    Methods named register and splitUrlAndDomain have been introduced in ServiceProvider and Manager classes respectively. The former is crucial for registering the service, whereas the latter helps in separating the URL from its domain name.

  • Updated Methods in 'Manager' Class
    The methods 'addKeyMappingData', 'hasMappingData', and 'invalidateCacheForUrl' in the Manager class have been revamped to include logic that separates the URL from its domain. This has been done to fetch the model and update the cache key to be invalidated.

  • Modification in 'TestCase' Class
    In TestCase class, an adjustment was made to the requirement statement for the 'statamic-cache' setup. This was necessary to ensure the compatibility and smooth running of the test cases.

@sylvesterdamgaard sylvesterdamgaard merged commit 6770131 into main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants